Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): should not be able to delete an identifier from a notification #1042

Conversation

iFergal
Copy link
Collaborator

@iFergal iFergal commented Mar 21, 2025

Description

This restricts deletion of identifiers to within the normal identifier flow. Deleting an identifier as a Related identifier link within a notification is entirely problematic, and an unnecessary flow. So this blocks that, and for consistency from within the credential details view too.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: [link]

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Before

After

Sorry, something went wrong.

…and not related views
@iFergal iFergal requested a review from sdisalvo-crd March 21, 2025 14:25
@iFergal iFergal self-assigned this Mar 21, 2025
Copy link
Contributor

@obstar obstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@iFergal iFergal merged commit f8986b3 into release/1.0.0 Mar 21, 2025
1 check passed
@iFergal iFergal deleted the fix/DTIS-2027-Should-not-be-able-to-delete-an-identifier-from-a-notification branch March 21, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants