Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude minification of all SQLCipher classes #1004

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

jimcase
Copy link
Contributor

@jimcase jimcase commented Mar 5, 2025

Description

When build the app through command line in Android Emulator - the app keep crashing.

Adding the flags from the doc above fixes the issue. Then,
npm run build:cap && cd android && ./gradlew assembleRelease

Source: link

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: [link]

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Sorry, something went wrong.

@jimcase jimcase self-assigned this Mar 5, 2025
@jimcase jimcase marked this pull request as ready for review March 5, 2025 15:55
@jimcase jimcase requested a review from iFergal March 5, 2025 16:10
@jimcase jimcase merged commit 0f177b4 into main Mar 5, 2025
1 check passed
@iFergal iFergal deleted the fix/sqlite-minification branch March 5, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants