Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/using freerasp #1003

Closed
wants to merge 3 commits into from
Closed

Feature/using freerasp #1003

wants to merge 3 commits into from

Conversation

jimcase
Copy link
Contributor

@jimcase jimcase commented Mar 5, 2025

Description

Please include a summary of the changes and a brief description about this PR

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: [link]

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

IOS

Before
After

Android

Before
After

Browser

Before
After

Sorry, something went wrong.

@jimcase jimcase self-assigned this Mar 5, 2025
@@ -1,6 +1,7 @@
<?xml version="1.0" encoding="utf-8" ?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
<uses-sdk android:minSdkVersion="29" android:targetSdkVersion="34" android:maxSdkVersion="34" />
<uses-feature android:name="android.hardware.camera" android:required="false" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The camera is not mandatory in order to use the app

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jimcase jimcase closed this Mar 11, 2025
@iFergal iFergal deleted the feature/using-freerasp branch March 25, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant