-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lxc: Add support for creating profile from yaml (from Incus) #13849
Merged
tomponline
merged 3 commits into
canonical:main
from
gabrielmougard:incus-pr/profile-from-yaml
Aug 5, 2024
Merged
lxc: Add support for creating profile from yaml (from Incus) #13849
tomponline
merged 3 commits into
canonical:main
from
gabrielmougard:incus-pr/profile-from-yaml
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@gabrielmougard added "(from Incus)" to PR description to help with attribution, please can you do this for future PRs. Ta |
tomponline
requested changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you add tests for this functionality.
tomponline
reviewed
Aug 2, 2024
Part of canonical#741 Signed-off-by: Vishesh Agrawal <[email protected]> (cherry picked from commit 7c84b4b60b864f722ac373db9f1ad3280edb9bd2) Signed-off-by: Gabriel Mougard <[email protected]> License: Apache-2.0
Signed-off-by: Gabriel Mougard <[email protected]>
7042c35
to
c98415c
Compare
tomponline
reviewed
Aug 3, 2024
c98415c
to
3f117a1
Compare
tomponline
reviewed
Aug 5, 2024
tomponline
reviewed
Aug 5, 2024
tomponline
reviewed
Aug 5, 2024
3f117a1
to
b50ecfc
Compare
tomponline
reviewed
Aug 5, 2024
tomponline
reviewed
Aug 5, 2024
b50ecfc
to
f99504e
Compare
Signed-off-by: Gabriel Mougard <[email protected]>
f99504e
to
dfd1773
Compare
tomponline
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picked from: lxc/incus#756