Make migration sink arguments private #13598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@MusicDin hows this one going? |
|
This one is expected to land after #13385 - there are all linter errors fixed. |
|
Time to rebase and update please |
Signed-off-by: Din Music <[email protected]>
MusicDin
force-pushed
the
fix/sink-args-visibility
branch
from
ceb23e3 to
422568f
Compare
|
@MusicDin looks like some static analysis issues |
Signed-off-by: Din Music <[email protected]>
MusicDin
force-pushed
the
fix/sink-args-visibility
branch
from
422568f to
7cce349
Compare
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
MusicDin
force-pushed
the
fix/sink-args-visibility
branch
from
7cce349 to
0291b46
Compare
tomponline
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just makes the migrations sink arguments private.