shared: Add helper for obtaining a CertInfo struct #12767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CertInfo is used across several LXD-adjacent projects to store certs, but it really only allows populating from a filesystem or from a set of bytes which results in a lot of back-and-forth conversions. This introduces a function that instantiates a new CertInfo with the given keypair/ca/crl parameters. Signed-off-by: Max Asnaashari <[email protected]>
tomponline
reviewed
Jan 23, 2024
Signed-off-by: Max Asnaashari <[email protected]>
I've added it to the |
tomponline
approved these changes
Jan 24, 2024
Yeah that avoids accidental modification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CertInfo is used across several LXD-adjacent projects to store certs, but it really only allows populating from a filesystem or from a slice of bytes which results in a lot of back-and-forth conversions:
lxd/shared/cert.go
Line 48 in 1f42fd0
This introduces a function that instantiates a new CertInfo with the given keypair/ca/crl parameters.