client: Pass a flag into queryOperation to skip event listener setup if not required.
#12349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2023
tomponline
reviewed
Oct 6, 2023
It's tricky because |
tomponline
reviewed
Oct 6, 2023
markylaing
force-pushed
the
exec-events
branch
from
2ca90c9 to
e2398fd
Compare
markylaing
changed the title
queryOperation to skip event listener setup if not required.
|
@tomponline I've changed this to roughly what we discussed on IRC (unless I've misunderstood). I have only skipped the event listener setup for |
tomponline
reviewed
Oct 6, 2023
tomponline
reviewed
Oct 6, 2023
|
looks like tests are sad |
markylaing
force-pushed
the
exec-events
branch
from
e2398fd to
4ef7b14
Compare
Signed-off-by: Mark Laing <[email protected]>
markylaing
force-pushed
the
exec-events
branch
from
4ef7b14 to
f0ff3f0
Compare
|
@tomponline tests should pass now if you have time to re-review. As a side note, I think a long-term solution to this problem might be to have a |
tomponline
reviewed
Oct 10, 2023
tomponline
reviewed
Oct 10, 2023
markylaing
force-pushed
the
exec-events
branch
from
f0ff3f0 to
c19f041
Compare
tomponline
previously approved these changes
Oct 10, 2023
markylaing
commented
Oct 10, 2023
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
markylaing
force-pushed
the
exec-events
branch
from
c19f041 to
d812961
Compare
tomponline
approved these changes
Oct 10, 2023
markylaing
added a commit
to markylaing/lxd
that referenced
this pull request
Oct 12, 2023
After recent changes to the client in canonical#12349, when calling ExecInstance we wait for the operation to complete by directly calling the operation wait endpoint instead of listening for the event. When calling exec on a VM, the client is used to connect with the LXD agent over the devlxd socket. This was failing with a 404 because the endpoint didn't exist. Signed-off-by: Mark Laing <[email protected]>
markylaing
added a commit
to markylaing/lxd
that referenced
this pull request
Oct 12, 2023
After recent changes to the client in canonical#12349, when calling ExecInstance we wait for the operation to complete by directly calling the operation wait endpoint instead of listening for the event. When calling exec on a VM, the client is used to connect with the LXD agent via vsock. This was failing with a 404 because the endpoint didn't exist. Signed-off-by: Mark Laing <[email protected]>
tomponline
pushed a commit
to tomponline/lxd
that referenced
this pull request
Nov 30, 2023
After recent changes to the client in canonical#12349, when calling ExecInstance we wait for the operation to complete by directly calling the operation wait endpoint instead of listening for the event. When calling exec on a VM, the client is used to connect with the LXD agent via vsock. This was failing with a 404 because the endpoint didn't exist. Signed-off-by: Mark Laing <[email protected]>
tomponline
pushed a commit
to tomponline/lxd
that referenced
this pull request
Nov 30, 2023
After recent changes to the client in canonical#12349, when calling ExecInstance we wait for the operation to complete by directly calling the operation wait endpoint instead of listening for the event. When calling exec on a VM, the client is used to connect with the LXD agent via vsock. This was failing with a 404 because the endpoint didn't exist. Signed-off-by: Mark Laing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it not always necessary to set up an event listener when interacting with operations via the client. For example, many client methods call
queryOperationand then callWaiton the returned operation. Instead of receiving all events, filtering by operation, then filtering by the ID of the operation, and checking the status code for "success" or "failure", we can just use/1.0/operations/wait.