zfs: Disallow block.* settings for regular custom block volumes #12203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@monstermunchkin please could you update the PR title |
monstermunchkin
changed the title
monstermunchkin
force-pushed
the
issues/12188-block-fileystem
branch
from
7ffb33d to
7469de4
Compare
simondeziel
reviewed
Sep 1, 2023
|
We should also add some tests for these keys being blocked. |
monstermunchkin
force-pushed
the
issues/12188-block-fileystem
branch
from
7469de4 to
e5a41df
Compare
tomponline
reviewed
Sep 4, 2023
Fixes canonical#12188 Signed-off-by: Thomas Hipp <[email protected]>
Signed-off-by: Thomas Hipp <[email protected]>
monstermunchkin
force-pushed
the
issues/12188-block-fileystem
branch
from
3842469 to
85b146a
Compare
tomponline
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12188
Signed-off-by: Thomas Hipp [email protected]