-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc/manpages: add the man pages to the docs #12165
Conversation
e508998
to
33f25d1
Compare
2863eba
to
110a098
Compare
110a098
to
e5813fc
Compare
doc/conf.py
Outdated
|
||
# Download lxc client | ||
|
||
if not os.path.isfile('.sphinx/deps/bin.linux.lxc'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there somewhere else we can move the downloading of dependencies out to, like a github workflow or a readthedocs hook, as I'd like to avoid building the docs from a version of the client that is different to the one running locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed - let's change to using lxc
for local builds (the tool should be in the path if the environment is set up correctly) and building the tool on RTD (see https://github.com/canonical/lxd/blob/main/.github/workflows/tests.yml#L274 ).
67fedb3
to
f8a785e
Compare
It looks like the doc build on GitHub is using the |
If you're always building the lxc command based on the local source code version then you could modify the lxc invocation to specify the local build target file rather than just executing |
Yes, but how do I know where the built file is? Line 41 in 9136ce4
|
You can use the value of
Alternatively, I believe I linked to it during our meeting, but the github work flows for the client testing use a slightly different invocation: https://github.com/canonical/lxd/blob/main/.github/workflows/tests.yml#L274 To build the binary in a local directory, so it can be used directly. |
Yes, that's what I'm doing for the RTD build, which works fine - but I don't want to add a second target for building the client to the Makefile. I'll see if I can get the |
Why do you need a 2nd target, cant you do the build in the hook itself? |
We have three different build environments: RTD, local build, and GitHub.
|
Ah I thought you were just going to build a local lxc for it in all environments. |
f8a785e
to
9e5fa56
Compare
Generate the man pages for the `lxc` command and add them to the reference documentation. Signed-off-by: Ruth Fuchss <[email protected]>
Signed-off-by: Ruth Fuchss <[email protected]>
Add references from mentions of the lxc commands to the corresponding man pages. Signed-off-by: Ruth Fuchss <[email protected]>
9e5fa56
to
f8f21e8
Compare
Working now 😄 |
Generate the man pages for the
lxc
command and add them to the reference documentation.Draft PR for now to see if this works on RTD.
If it does, I'll check if I can group the output a bit better (instead of having 300 pages on the same level in the TOC ;) ).