QEMU: Occupy vsock Context ID through syscall #11993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
reviewed
Jul 11, 2023
roosterfish
force-pushed
the
fix_vsock_startup_race
branch
from
c5072cf to
d5401c3
Compare
Signed-off-by: Julian Pelizäus <[email protected]>
roosterfish
force-pushed
the
fix_vsock_startup_race
branch
from
d5401c3 to
769c415
Compare
roosterfish
changed the title
roosterfish
force-pushed
the
fix_vsock_startup_race
branch
from
769c415 to
e01abe9
Compare
tomponline
reviewed
Jul 12, 2023
tomponline
reviewed
Jul 12, 2023
tomponline
reviewed
Jul 12, 2023
roosterfish
force-pushed
the
fix_vsock_startup_race
branch
4 times, most recently
from
780b4d4 to
e30f707
Compare
tomponline
reviewed
Jul 13, 2023
tomponline
reviewed
Jul 13, 2023
roosterfish
force-pushed
the
fix_vsock_startup_race
branch
from
e30f707 to
5b7a53b
Compare
tomponline
reviewed
Jul 13, 2023
roosterfish
force-pushed
the
fix_vsock_startup_race
branch
from
5b7a53b to
b666277
Compare
tomponline
approved these changes
Jul 13, 2023
|
I have created a small script for testing those scenarios, the outcome is what we expect. Gist: https://gist.github.com/roosterfish/ea62fe1f7fff2838eb786d4444901c1c |
|
@roosterfish you could open a PR on https://github.com/canonical/lxd-ci put it in a new "tests" directory please |
tomponline
reviewed
Jul 13, 2023
roosterfish
force-pushed
the
fix_vsock_startup_race
branch
from
b666277 to
5d81e22
Compare
|
@roosterfish did your manual tests pass OK ? |
monstermunchkin
suggested changes
Jul 13, 2023
tomponline
reviewed
Jul 13, 2023
When trying to acquire a new vsock Context ID, we want to occupy it right away to prevent collisions. This helps for scenarios where two VMs have the same identical volatile.vsock_id (VM export/import) and in case LXD is used in a nested environment. If either the acquisition or the syscall fails, the next one gets selected. Signed-off-by: Julian Pelizäus <[email protected]>
roosterfish
force-pushed
the
fix_vsock_startup_race
branch
from
5d81e22 to
293f36f
Compare
monstermunchkin
approved these changes
Jul 13, 2023
Yes, all clear. |
|
@roosterfish thanks for your thoroughness on picking up these issues and fixing them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to acquire a new vsock Context ID, we want to occupy it right away to prevent collisions.
This helps for scenarios where two VMs have the same identical volatile.vsock_id (VM export/import) and
in case LXD is used in a nested environment.
If either the acquisition or the syscall fails, the next one gets selected.
Follow up on #11896 and observed during investigation of #11907