Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the headings in multiple functions of the config.go file #11985

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Added the headings in multiple functions of the config.go file #11985

merged 1 commit into from
Jul 13, 2023

Conversation

ibilalkayy
Copy link
Contributor

Hey there,

I just added the headings in multiple functions of the config.go file.

Thank you!

@monstermunchkin
Copy link
Contributor

monstermunchkin commented Jul 11, 2023

@ibilalkayy Please stick to a single PR for all the header changes you make. That will make it easier to review.

Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think having fewer PRs, still with several commits to allow backport would be better than a steady stream of small PRs.

Also I'd like to understand more about the reasons you are making these changes?

Are you working on a project that is using LXD?

@ibilalkayy
Copy link
Contributor Author

ibilalkayy commented Jul 11, 2023

@tomponline No I am not currently working on a project that is using LXD but instead, I found this project responsive because I checked some of the closed PRs and saw that the discussion was really helpful and this is enough for me at least to start contributing into it. Currently, I am learning how the LXD works and I am playing with it.

@ibilalkayy
Copy link
Contributor Author

@monstermunchkin Alright. I will send a single PR with multiple commits. I apologize for my mistake.

@tomponline tomponline merged commit f1bd9bb into canonical:main Jul 13, 2023
@ibilalkayy ibilalkayy deleted the config_file branch July 14, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants