Merge pull request #12066 from montag451/socks5-proxy

shared/proxy: allow SOCKS5 proxy
canonical · Jul 24, 2023 · 9ffb12a · 9ffb12a
2 parents f814ba6 + d9af620
commit 9ffb12a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/shared/proxy.go b/shared/proxy.go
@@ -94,7 +94,7 @@ func ProxyFromConfig(httpsProxy string, httpProxy string, noProxy string) func(r
 		}
 
 		proxyURL, err := url.Parse(proxy)
-		if err != nil || !strings.HasPrefix(proxyURL.Scheme, "http") {
+		if err != nil || (!strings.HasPrefix(proxyURL.Scheme, "http") && proxyURL.Scheme != "socks5") {
 			// proxy was bogus. Try prepending "http://" to it and
 			// see if that parses correctly. If not, we fall
 			// through and complain about the original one.