Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning pbr<6.1.1 so it continues to use setuptools #229

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Feb 11, 2025

Pinning pbr<6.1.1 to deal with install hook issue on reactive charms that depend on charmhelpers.

Layer basic pins setuptools to a version which cannot install pbr.

2025-02-11 21:18:08 DEBUG unit.openstack-integrator/0.install logger.go:60 Processing ./wheelhouse/pbr-6.1.1.tar.gz
2025-02-11 21:18:08 DEBUG unit.openstack-integrator/0.install logger.go:60   Installing build dependencies: started
2025-02-11 21:18:09 DEBUG unit.openstack-integrator/0.install logger.go:60   Installing build dependencies: finished with status 'error'
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60   error: subprocess-exited-with-error
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60   
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60   × pip subprocess to install build dependencies did not run successfully.
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60   │ exit code: 1
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60   ╰─> [4 lines of output]
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60       Looking in links: wheelhouse
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60       Ignoring setuptools: markers 'python_version < "3.7"' don't match your environment
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60       ERROR: Could not find a version that satisfies the requirement setuptools>=64.0.0 (from versions: 62.1.0)
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60       ERROR: No matching distribution found for setuptools>=64.0.0
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60       [end of output]
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60   
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60   note: This error originates from a subprocess, and is likely not a problem with pip.
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60 error: subprocess-exited-with-error
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60 
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60 × pip subprocess to install build dependencies did not run successfully.
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60 │ exit code: 1
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60 ╰─> See above for output.
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60 
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60 note: This error originates from a subprocess, and is likely not a problem with pip.
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60 Traceback (most recent call last):
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60   File "/var/lib/juju/agents/unit-openstack-integrator-0/charm/hooks/install", line 8, in <module>
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60     basic.bootstrap_charm_deps()
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60   File "/var/lib/juju/agents/unit-openstack-integrator-0/charm/lib/charms/layer/basic.py", line 224, in bootstrap_charm_deps
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60     check_call([pip, 'install', '-U', reinstall_flag, '--no-index',
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60   File "/usr/lib/python3.10/subprocess.py", line 369, in check_call
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60     raise CalledProcessError(retcode, cmd)
2025-02-11 21:18:09 WARNING unit.openstack-integrator/0.install logger.go:60 subprocess.CalledProcessError: Command '['/var/lib/juju/agents/unit-openstack-integrator-0/.venv/bin/pip', 'install', '-U', '--force-reinstall', '--no-index', '--no-cache-dir', '-f', 'wheelhouse', 'marshmallow-enum==1.5.1', 'tomli==2.2.1', 'tenacity==9.0.0', 'Cython==0.29.37', 'sniffio==1.3.0', 'marshmallow==3.22.0', 'flit-core==3.10.1', 'cached-property==2.0.1', 'pbr==6.1.1', 'websocket-client==1.8.0', 'ops-reactive-interface==1.1.0', 'pyyaml==6.0.2', 'str2bool==1.1', 'charmhelpers==1.2.1', 'jinja2==3.1.5', 'ops==2.18.1', 'idna==3.10', 'loadbalancer-interface==1.2.0', 'anyio==3.6.2', 'flit-scm==1.7.0', 'packaging==24.2', 'netaddr==0.7.19', 'charms-reactive==1.5.3', 'pyaml==21.10.1']' returned non-zero exit status 1.

@addyess addyess force-pushed the bug/lp2098017/pin-pbr branch from 4ae157e to 8b6bde1 Compare February 11, 2025 22:27
Comment on lines +34 to +35
env:
PIP_TRUSTED_HOST: "pypi.python.org pypi.org files.pythonhosted.org"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@gboutry gboutry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix

@gboutry gboutry merged commit 3384ec3 into canonical:master Feb 12, 2025
8 checks passed
@addyess addyess deleted the bug/lp2098017/pin-pbr branch February 12, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants