feat(k8sd): introduce feature packages and update feature apply functions #1119
+2,771
−1,536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berkayoz
force-pushed
the
KU-2730/helm-charts-microcluster
branch
from
6c4f9cd to
3ae6337
Compare
berkayoz
force-pushed
the
KU-2731/feature-manifest
branch
from
adca897 to
d20d506
Compare
berkayoz
force-pushed
the
KU-2730/helm-charts-microcluster
branch
from
3ae6337 to
4dbf70a
Compare
berkayoz
force-pushed
the
KU-2731/feature-manifest
branch
2 times, most recently
from
0e7cae0 to
e6d71ea
Compare
berkayoz
force-pushed
the
KU-2730/helm-charts-microcluster
branch
from
4dbf70a to
4883123
Compare
berkayoz
force-pushed
the
KU-2731/feature-manifest
branch
from
e6d71ea to
2695bc6
Compare
bschimke95
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
We discussed most of those changes offline already, so just a few minor comments.
Great work @berkayoz
bschimke95
force-pushed
the
KU-2731/feature-manifest
branch
3 times, most recently
from
8aec69a to
4fd44bc
Compare
…ions - Added the FeatureManifest struct that contains the required charts and images for the feature. - Features are updated to use feature manifests when reconciling through the feature controller. - Implementation modules under `features` are updated to contain sub modules per feature. - Values handling is separated from the `Apply` functions and is performed via helper functions instead. - Introduced helper `Values` types and related functions for merging values together using mergo. --------- Co-authored-by: Benjamin Schimke <[email protected]>
berkayoz
force-pushed
the
KU-2731/feature-manifest
branch
from
f547793 to
566c338
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
featuresare updated to contain sub modules per feature.Applyfunctions and is performed via helper functions instead.Valuestypes and related functions for merging values together using mergo.