Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on bytecode-only compilers #5

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Build on bytecode-only compilers #5

merged 1 commit into from
Oct 4, 2019

Conversation

aantron
Copy link
Contributor

@aantron aantron commented Oct 4, 2019

On 4.05.0+bytecode-only without this patch:

$ opam install seq
# + ocamlopt -c -g -I src -o src/seq.cmx src/seq.ml
# /bin/sh: 1: ocamlopt: not found
# Command exited with code 127.
# Makefile:12: recipe for target 'build' failed
# make: *** [build] Error 10

With this patch:

$ opam install seq
Done.

I installed Lwt on 4.05.0+bytecode-only using the patched seq, and it seems to work fine.

Also confirmed that the patched seq still works on regular switches, again by installing Lwt and running its tests. I also looked in lib/seq/ to check that the cmxa and cmxs files are present. The switch was the regular 4.05.0.

I tried to write the code in such a way that it will not break on Windows. In particular, it doesn't assume a which command, or the name /dev/null. As a result, it prints one line to standard error if ocamlopt is not found. However, that line is probably not shown by most package managers. In particular, it has no effect on the opam output.

@c-cube c-cube merged commit b191eea into c-cube:master Oct 4, 2019
@c-cube
Copy link
Owner

c-cube commented Oct 4, 2019

Thanks, that's a very good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants