-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to search for notes #85
Conversation
…and search notes route on the backend. The filtered list of notes is held in the context
Add ability to search for notes
@devarshishimpi Can't seem to assign you to this |
Done, will review in sometime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmathew98 Interesting. Not sure what was added there like enhancement, since yes, Seach for notes did get merged by @abhinandanwadwa . Is there any sort of enhancement over the current search code? Or, could you elaborate your PR since search functionality did get added
Also, I see some merge conflicts in the packagejson file.
No actual improvement in terms of functionality to be honest haha, was just looking for the Hacktoberfest PR. Ah sorry about the merge conflicts in |
@nmathew98 The previous one had some bugs, looks like this one fixes it as well!! Valid Contribution!!! Thank You!!! |
Ah ok, that's great to hear, thanks very much! :D |
Describe your changes
Issue: #54
Added NotesContext on the frontend, and search notes route on the backend. The filtered list of notes is held in the context. If no search text is provided, all notes are fetched if there is a search text then we get the filtered list.
Screenshots - If Any (Optional)
Issue ticket number and link - If Any
Checklist before requesting a review
I have performed a self-review of my code.
Followed the repository's Contributing Guidelines.
I ran the app and tested it locally to verify that it works as expected.
I have starred the repository.
Additional Information (Optional)