Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to search for notes #85

Merged
merged 6 commits into from
Oct 8, 2022
Merged

Add ability to search for notes #85

merged 6 commits into from
Oct 8, 2022

Conversation

nmathew98
Copy link
Contributor

@nmathew98 nmathew98 commented Oct 8, 2022

Describe your changes

Issue: #54
Added NotesContext on the frontend, and search notes route on the backend. The filtered list of notes is held in the context. If no search text is provided, all notes are fetched if there is a search text then we get the filtered list.

Screenshots - If Any (Optional)

Issue ticket number and link - If Any

Checklist before requesting a review

  • I have performed a self-review of my code.

  • Followed the repository's Contributing Guidelines.

  • I ran the app and tested it locally to verify that it works as expected.

  • I have starred the repository.

Additional Information (Optional)

…and search notes route on the backend. The filtered list of notes is held in the context
Add ability to search for notes
@nmathew98
Copy link
Contributor Author

@devarshishimpi Can't seem to assign you to this

@devarshishimpi
Copy link
Member

this

Done, will review in sometime

Copy link
Member

@devarshishimpi devarshishimpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmathew98 Interesting. Not sure what was added there like enhancement, since yes, Seach for notes did get merged by @abhinandanwadwa . Is there any sort of enhancement over the current search code? Or, could you elaborate your PR since search functionality did get added

Also, I see some merge conflicts in the packagejson file.

@nmathew98
Copy link
Contributor Author

nmathew98 commented Oct 8, 2022

@nmathew98 Interesting. Not sure what was added there like enhancement, since yes, Seach for notes did get merged by @abhinandanwadwa . Is there any sort of enhancement over the current search code? Or, could you elaborate your PR since search functionality did get added

Also, I see some merge conflicts in the packagejson file.

No actual improvement in terms of functionality to be honest haha, was just looking for the Hacktoberfest PR. Ah sorry about the merge conflicts in package-lock.json. Feel free to close if not needed, I think the NotesContext is an improvement since it centralises the logic for adding notes but other than that nothing much

@devarshishimpi devarshishimpi added hacktoberfest Hacktoberfest hacktoberfest-accepted Hacktoberfest Accepted hacktoberfest2022 Hacktoberfest 2022 labels Oct 8, 2022
@devarshishimpi devarshishimpi added this to the v2.0-roadmap milestone Oct 8, 2022
@devarshishimpi devarshishimpi merged commit 4644a5c into bytemakers:main Oct 8, 2022
@devarshishimpi
Copy link
Member

@nmathew98 The previous one had some bugs, looks like this one fixes it as well!! Valid Contribution!!! Thank You!!!

@nmathew98
Copy link
Contributor Author

Ah ok, that's great to hear, thanks very much! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest hacktoberfest2022 Hacktoberfest 2022 hacktoberfest-accepted Hacktoberfest Accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants