Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerfile #179

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Conversation

mpeiffer
Copy link
Contributor

@mpeiffer mpeiffer commented Oct 20, 2022

Describe your changes

Added a docker-compose file to connect to MongoDB and build the backend and frontend.

Screenshots - If Any (Optional)

After running docker-compose up and navigating to localhost:3000:
Screenshot 2022-10-20 at 07-51-47 Noteslify

Issue ticket number and link - If Any

Issue #158

Checklist before requesting a review

  • I have performed a self-review of my code.

  • Followed the repository's Contributing Guidelines.

  • I ran the app and tested it locally to verify that it works as expected.

  • I have starred the repository.

Additional Information (Optional)

I had to edit the db.js file so that it uses the correct MongoDB path based on what type of build you are running. I tested that the original way (outlined in the README) works in addition to the docker-compose way.

@abhinandanwadwa abhinandanwadwa self-requested a review October 20, 2022 16:21
@devarshishimpi devarshishimpi self-requested a review October 20, 2022 16:46
Copy link
Member

@devarshishimpi devarshishimpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks For Contributing!!!

@devarshishimpi devarshishimpi merged commit d812799 into bytemakers:main Oct 20, 2022
@devarshishimpi devarshishimpi added enhancement New feature or request v2.0-roadmap Version 2.0 Roadmap hacktoberfest Hacktoberfest hacktoberfest-accepted Hacktoberfest Accepted hacktoberfest2022 Hacktoberfest 2022 labels Oct 20, 2022
@devarshishimpi devarshishimpi added this to the v2.0-roadmap milestone Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest Hacktoberfest hacktoberfest2022 Hacktoberfest 2022 hacktoberfest-accepted Hacktoberfest Accepted v2.0-roadmap Version 2.0 Roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants