added active class #139
added active class #139
Conversation
|
@biswajit035 Kindly complete all steps as requested before review |
| .active{ | ||
| background-color: #e4e9f7; | ||
| } | ||
|
|
There was a problem hiding this comment.
for active class background color
| @@ -89,7 +90,7 @@ const Sidenav = () => { | |||
| </a> | |||
| </li> | |||
|
|
|||
| <li className="nav-link"> | |||
| <li className={`nav-link ${location === '/bin' ? "active" : ""}`}> | |||
There was a problem hiding this comment.
For automatically adding the active class according to the url
| <Link to={'/notes'}> | ||
| <i className="fa-solid fa-house icon"></i> | ||
| <span className="text nav-text">Dashboard</span> | ||
| </Link> | ||
| </li> | ||
|
|
||
| <li className="nav-link"> | ||
| <li className={`nav-link ${location === '/myaccount' ? "active" : ""}`}> |
There was a problem hiding this comment.
For automatically adding the active class according to the url
| @@ -68,14 +69,14 @@ const Sidenav = () => { | |||
| </li> | |||
|
|
|||
| <ul className="menu-links"> | |||
| <li className="nav-link"> | |||
| <li className={`nav-link ${location === '/notes'?"active":""}`}> | |||
There was a problem hiding this comment.
For automatically adding the active class according to the url
|
This is my 2nd PR of my first OPENSOURCE, So I have no idea what to do now. |
That's it, it will be merged |
devarshishimpi
added
enhancement
It is merged but when I am going to https://noteslify.stonecss.com/notes this features is not working. |
|
Yes, you are right. The feature will be brought into production on the next release ( Maybe today or tomorrow ) |
Describe your changes
I have added a ACTIVE class so that user can get idea about his active tab in NAVBAR
Screenshots - If Any (Optional)
Issue ticket number and link -
#138
Checklist before requesting a review
I have performed a self-review of my code.
Followed the repository's Contributing Guidelines.
I ran the app and tested it locally to verify that it works as expected.
I have starred the repository.
Additional Information (Optional)