Skip to content

Commit

Permalink
windows: upgrade msvc version
Browse files Browse the repository at this point in the history
Note: the msvc version in Github's documentation is incorrect.
Reported via actions/runner-images#11730
  • Loading branch information
sluongng committed Mar 5, 2025
1 parent 17516b8 commit ef80284
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ buildbuddy = use_extension("@toolchains_buildbuddy//:extensions.bzl", "buildbudd
buildbuddy.platform(buildbuddy_container_image = "UBUNTU20_04_IMAGE")
buildbuddy.msvc_toolchain(
# This is the MSVC available on Github Action win22 image
# https://github.com/actions/runner-images/blob/win22/20250127.1/images/windows/Windows2022-Readme.md
# https://github.com/actions/runner-images/blob/win22/20250303.1/images/windows/Windows2022-Readme.md
msvc_edition = "Enterprise",
msvc_release = "2022",
# From 'Microsoft Visual C++ 2022 Minimum Runtime' for x64 architecture
# https://github.com/actions/runner-images/blob/win22/20250127.1/images/windows/Windows2022-Readme.md#microsoft-visual-c
msvc_version = "14.42.34433",
# https://github.com/actions/runner-images/blob/win22/20250303.1/images/windows/Windows2022-Readme.md#microsoft-visual-c
msvc_version = "14.43.34808",
)

switched_rules = use_extension("@googleapis//:extensions.bzl", "switched_rules")
Expand Down
6 changes: 3 additions & 3 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -558,12 +558,12 @@ buildbuddy(
name = "buildbuddy_toolchain",
container_image = UBUNTU20_04_IMAGE,
# This is the MSVC available on Github Action win22 image
# https://github.com/actions/runner-images/blob/win22/20250127.1/images/windows/Windows2022-Readme.md
# https://github.com/actions/runner-images/blob/win22/20250303.1/images/windows/Windows2022-Readme.md
msvc_edition = "Enterprise",
msvc_release = "2022",
# From 'Microsoft Visual C++ 2022 Minimum Runtime' for x64 architecture
# https://github.com/actions/runner-images/blob/win22/20250127.1/images/windows/Windows2022-Readme.md#microsoft-visual-c
msvc_version = "14.42.34433",
# https://github.com/actions/runner-images/blob/win22/20250303.1/images/windows/Windows2022-Readme.md#microsoft-visual-c
msvc_version = "14.43.34808",
)

http_archive(
Expand Down

0 comments on commit ef80284

Please sign in to comment.