Skip to content

Fix argument order sent via command line to browserstack local binary. #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix argument order sent via command line to browserstack local binary. #38

wants to merge 1 commit into from

Conversation

stevenlybeck
Copy link

Previously, the folder flag and folder value were split by the key argument.

Fix argument order sent via command line to browserstack local binary.
b011caf 
Previously, the folder flag and folder value were split by the key argument.
@stevenlybeck
Copy link
Author

If you logged the output of this.getBinaryArgs().join(" ") right before it gets passed to execFile() - you find that this is the output:

-f --key 00000000000000000 /folder/option/string/goes-here

This PR brings the -f flag and folder string back together.

@pankaj-a
Copy link
Contributor

Merged in #62. Closing this. Thanks @stevenlybeck for the fix.

@pankaj-a pankaj-a closed this Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenlybeck @pankaj-a