Add prettier and reformat code #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally this project would have a mechanism for enforcing the prettier configuration and fail any commits that deviate from it. This could be automated either with git hooks or with a step in the CI pipeline. Do you have any thoughts on this? |
|
We could maybe add prettier as a blocking step in the minor,patch,major Makefile targets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add prettier with config identical to main node-postgres module. Reformat all code. This change follows guidelines set here brianc/node-postgres#2172
The eslint config mentioned in the linked issue is targeted for TypeScript and doesn't add anything for non-TS projects. So let's go with prettier only for now and think of adding eslint when migrating to TypeScript in the future.