Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: cross-seed.sh #40

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fabricionaweb
Copy link

@fabricionaweb fabricionaweb commented Dec 27, 2024

Hi, I'd like to contribute with a script to install cross-seed.

My goal is to add it to the HBD docs as well. I have tested on my box, but sure I need more feedbacks.

Basically needs nvm to get nodejs and npm.
Tthere is the user daemon and its using nvm-exec (way better than using the absolute nodejs path).
And set some values on the config based on installed clients.

Users would need to trick a lot on the config and will be asking a lot of help that is for sure... but I believe this can be a good start point.

Also I think it would not conflict with the other apps using nvm (thelounge, overseerr/jellyseer)

@fabricionaweb fabricionaweb force-pushed the cross-seed branch 3 times, most recently from 628a3bd to 3d170c2 Compare December 29, 2024 00:06
@fabricionaweb fabricionaweb force-pushed the cross-seed branch 11 times, most recently from a94a4d2 to b05c29f Compare December 29, 2024 01:42
@brettpetch
Copy link
Owner

brettpetch commented Dec 29, 2024

Any reason that we’re pushing latest node here instead of LTS?

I see in the documentation for cross-seed that it’s built to support node 20 or above, and since our other applications use LTS we could keep our dependencies smaller in the interest of saving users a bit of space. Otherwise looks good.

@fabricionaweb
Copy link
Author

fabricionaweb commented Dec 29, 2024

Any reason that we’re pushing latest node here instead of LTS?

I see in the documentation for cross-seed that it’s built to support node 20 or above, and since our other applications use LTS we could keep our dependencies smaller in the interest of saving users a bit of space. Otherwise looks good.

Hmm but its using the same --lts flag like the others scripts. Here its pulling 22.12

What you may strange at first sight is that v22 became lts recently (oct 2024) https://nodesource.com/blog/Node.js-v22-Long-Term-Support-LTS

What can be done is check if already have a node installed and use that instead of let nvm pull lts

@fabricionaweb
Copy link
Author

fabricionaweb commented Dec 29, 2024

I sent that last commit, nvm is smart to use any minor version available giving the major. I think it looks good, it can use 22, 20 or install a fresh lts (as today it would be 22.12)

But Im seeing a problem, the port 2468 is being used... (someone else in the box maybe bind 0.0.0.0 to it) I think it will need to randomize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants