feat(ratios): always return 24h change in GetRelative service #2783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GetRelative
appears to be triggering a request to fetch market chart for single coingecko id requests, for a piece of data which doesn't seem to be that useful to Brave Wallet.We'll now always be copying the 24H % change to
<currency>_timeframe_change
field, ignoring whateverduration
is specified by the caller. In the future, we'll removeduration
as a parameter to the corresponding controller since it doesn't make semantic sense to have it.Related to brave/brave-browser#44557
Type of Change
Tested Environments
Before Requesting Review
Manual Test Plan
Ensure hitting the endpoint returns the 24h change regardless of the duration. For example, the following endpoints should have the same result for
usd_timeframe_change
: