fix(ratios): ignore invalid and empty coingecko ids #2771
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our CoinGecko API usage is through the roof, putting us at risk of service discontinuation unless we significantly reduce our requests. This PR aims to reduce Coingecko API usage.
The way clients query token prices using the Ratios service is as follows:
A batched request can fail for invalid/unknown Coingecko IDs in the request, but rejecting the entire batch for even a single such ID is sub-optimal. This PR ensures that such IDs are ignored and we return prices for the remaining valid Coingecko IDs in the request (if any).
Before
After
Type of Change
Tested Environments
Before Requesting Review
Manual Test Plan
Tested locally on my branch. Once deployed to staging, I'll test with a local build of brave-core.