-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove flatpak filesystem permissions #460
Conversation
FLATPAK_ID as introduced in flatpak 1.1.2
c42bd1c
to
7c85906
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the second point is the better choice but should be implemented only for flatpak users as other packages has not these restrictions: #413 (comment) |
@mirkobrombin so you mean
How do you feel about instructions in the README.md of the Flathub Bottles repository for now? |
That may be fine but most users won't reach that repository. Perhaps it is better to at least allow access to the home folder. What do you think? I don't like the idea of exposing the home but I'm afraid no user will appreciate this change and maybe it's too difficult to find that information. |
Maybe the third option is the best
With a simple tutorial the user will be introduced to the new feature. |
Nah, either we say "sandboxed" and we provide a way for users to punch holes at will. Or we say "Bottles needs fs" in which case we might as well leave gvfs, I'm strongly in favor of the first even if it's more work. If users don't care about sandboxing they can use AppImage, Snap, distribution package, ... What about we show a "Give filesystem access" button in the bottle to flatpak users that opens the documentation on how to for now? Later (no promises) I would like to investigate into using the documen portal for this. There is a persistent option https://github.com/flatpak/xdg-desktop-portal/blob/89d2197002f164d02d891c530dcaa2808f27f593/data/org.freedesktop.portal.Documents.xml#L73 Related: flatpak/xdg-desktop-portal#133 |
Yes, I think it's a good idea to add the button. |
We should merge and open a new issue for button documentation. Is it ok? |
Co-authored-by: Sonny Piers <[email protected]>
Yes, please go ahead. I will take care of creating the issue - I want to give it some thoughts with a concrete proposal, and it's tracked in #413 anyway. |
Fixes #413
I found several issues with hardcoded paths so I will end a PR for that after.