Don't fail in patterns of the …*/… form
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal matchDir would always fail if we were trying to match against a separator after as it gave up before the separator even had the chance to be consumed. Closes bos#9
Fuuzetsu
added a commit
to Fuuzetsu/hpack
that referenced
this pull request
Jul 4, 2015
This nearly works, we're just missing */ patterns due to bos/filemanip#10
Fuuzetsu
added a commit
to Fuuzetsu/hpack
that referenced
this pull request
Jul 5, 2015
As filemanip suffers from bos/filemanip#10 Glob conveniently provides ‘globDir’ which expands all the patterns for us but it does not provide the list of patterns which did not match anything. To do that, we ‘globDir’ with just one pattern and then ‘match’ on all files it has encountered: this approach means we still only traverse the tree once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal matchDir would always fail if we were trying to match against a
separator after as it gave up before the separator even had the chance
to be consumed.
Closes #9