Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size verification for Paillier public keys #466

Closed
2 tasks done
marsella opened this issue Aug 15, 2023 · 0 comments · Fixed by #479
Closed
2 tasks done

Add size verification for Paillier public keys #466

marsella opened this issue Aug 15, 2023 · 0 comments · Fixed by #479
Assignees
Labels
bug Something isn't working

Comments

@marsella
Copy link

marsella commented Aug 15, 2023

The recent GG18/20 vulnerability hinges on signer's Paillier public keys having no small factors.

CGGMP avoids most of this by including ZK proofs that validate that the public keys are the product of two primes and that neither factor is "too big" (which would force the other factor to be too small if the overall modulus is large). However, I think we don't check the size of public Paillier moduli we receive from other parties, so small moduli might have small factors.

  • Add a size check to the CommitmentScheme::from_message method
  • Look through related types to see if we want to add a check anywhere else (e.g. AuxInfoPublic::new()?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants