This repository was archived by the owner on Oct 15, 2024. It is now read-only.

R4R: make msg decoding sync #122

Merged

unclezoro merged 1 commit into upgrade_0.32.3 from fix-memory-trample

Oct 8, 2019

Contributor

HaoyangLiu commented Oct 8, 2019

closes: #121

Updated all relevant documentation in docs
Updated all code comments where relevant
Wrote tests
Updated CHANGELOG_PENDING.md


          Move msg decoder forward, make msg decoding sync

ccdea53

unclezoro reviewed

View reviewed changes

mempool/reactor.go

-              	memR.recvCh <- &MempoolPacket{chID: chID, src: src, msgBytes: msgBytes}
+              	msg, err := memR.decodeMsg(msgBytes)
+              	if err != nil {
+              		memR.Logger.Error("Error decoding message", "src", src, "chId", chID, "msg", msg, "err", err, "bytes", msgBytes)

Collaborator

unclezoro Oct 8, 2019

Any testcase affected?

unclezoro merged commit d36242f into upgrade_0.32.3

HaoyangLiu mentioned this pull request

Revert "R4R: make msg decoding sync" #127

Merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet