Supermicro redfish inventory support #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… error Since redfish endpoints differ between vendors, hardware models, one or more collection methods part of Inventory() can fail, this bool value when false will cause Inventory() to ignore those errors and continue collection for whatever data is available. For now this bool parameter defaults to false, it can be exposed to the caller when such a need arises.
…or SMC hardware This fixes the collection methods to work with various SMC hardware as well. Tested on, SYS-5019C-MR 6029P-E1CR12L SYS-510T-MR
luke-jarymowycz
requested changes
Dec 8, 2022
Came across this issue when testing on a SYS-510T-MR that had NICs listed in redfish but no network adapters.
Codecov ReportBase: 46.53% // Head: 46.41% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
- Coverage 46.53% 46.41% -0.12%
==========================================
Files 27 27
Lines 2265 2273 +8
==========================================
+ Hits 1054 1055 +1
- Misses 1096 1103 +7
Partials 115 115
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Pushed a fix for a NIC collection issue identified in further testing. @luke-jarymowycz thanks for taking a look, I realised that was actually the older gist, |
luke-jarymowycz
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
Updates the Redfish provider inventory collection to work on Supermicro hardware,
6029P-E1CR12L.json
SYS-5019C-MR.json
SYS-510T-MR.json
Checklist
The HW vendor this change applies to (if applicable)
Supermicro
The HW model number, product name this change applies to (if applicable)
Should work with all SMC hardware, tested on hardware variants,
SYS-5019C-MR
6029P-E1CR12L
SYS-510T-MR
Description for changelog/release notes