Redfish refactor #296
Merged
Redfish refactor #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
force-pushed
the
redfish-refactor
branch
from
585f965 to
39d42a5
Compare
Codecov ReportBase: 43.69% // Head: 46.53% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
==========================================
+ Coverage 43.69% 46.53% +2.83%
==========================================
Files 27 27
Lines 2435 2265 -170
==========================================
- Hits 1064 1054 -10
+ Misses 1248 1096 -152
+ Partials 123 115 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
chrisdoherty4
previously approved these changes
Nov 28, 2022
|
@joelrebel Will wait for the rebase, ping when ready. |
This moves the redfish client wrapping outside of the providers/redfish package, these methods always check the redfish session is valid before calling into the wrapped redfish library - gofish. By moving this out, other providers can also import the redfishwrapper.
The redfishwrapper validates the redfish session is active before any calling into the redfish methods. The rest of changes tries to prevents direct interaction with the gofish library methods although the gofish objects are accessed as is.
joelrebel
force-pushed
the
redfish-refactor
branch
from
71105ec to
8448345
Compare
|
@chrisdoherty4 good to go now. |
chrisdoherty4
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
This is based on the feedback in #291
This moves the redfish client wrapping outside of the providers/redfish
package, these methods always check the redfish session is valid before
calling into the wrapped redfish library - gofish.
By moving this out, other providers can also import the redfishwrapper.