Add initial secure TLS options #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahhausler
force-pushed
the
allow-secure-tls
branch
9 times, most recently
from
bbe2802 to
8fee966
Compare
Signed-off-by: Micah Hausler <[email protected]>
micahhausler
force-pushed
the
allow-secure-tls
branch
from
8fee966 to
6782d1f
Compare
* Add mutexes on login/logout Signed-off-by: Micah Hausler <[email protected]>
joelrebel
approved these changes
Apr 25, 2022
| @@ -2,6 +2,7 @@ package main | |||
|
|
|||
| import ( | |||
There was a problem hiding this comment.
could this be moved under /examples/pre.v1
micahhausler
force-pushed
the
allow-secure-tls
branch
from
a927ad3 to
103d59b
Compare
Signed-off-by: Micah Hausler <[email protected]>
micahhausler
force-pushed
the
allow-secure-tls
branch
from
103d59b to
57124d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Micah Hausler [email protected]
This PR adds secure TLS options for consumers of different providers.
This does NOT yet allow the default bmclib client to enable TLS, as most of the client methods (Open(),CreateUser(), etc) and their corresponding interface implementations in/bmc(UserCreator,UserReader, etc) all instantiate connections without options.This depends on #265, and I'll rebase after that merges
The HW vendor this change applies to (if applicable)
The HW model number, product name this change applies to (if applicable)
N/A
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
N/A
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
N/A
Description for changelog/release notes