Fix lists tab appearing when user has a starterpack but no lists #7952
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rose for example has a starter pack but no lists, yet the tab appears in her profile:
https://bsky.app/profile/rose.bsky.team
This is because starter packs include a type of list inside of them, but since they don't show in the lists tab the tab appears but is empty.
This can be fixed by subtracting the number of starter packs from the lists agg count.
Test plan
Confirm Rose's profile has the correct tabs
Make a new account, and observe that the
associatedobject increases in the way I described (i.e. creating a SP adds +1 to bothlistsandstarterPacks, and curate/modlist only adds +1 tolists)