Remove use left convos #7874
Open
Remove use left convos #7874
+25
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DogPawHat
commented
Mar 1, 2025
| onMutate, | ||
| onError, | ||
| }: { | ||
| onMutate?: () => void | ||
| onSuccess?: (data: ChatBskyConvoLeaveConvo.OutputSchema) => void |
There was a problem hiding this comment.
Didn't see this option being used at all. Easy enough to add back in if you need it.
Comment on lines
80
to
83
| onSettled: () => { | ||
| queryClient.invalidateQueries({queryKey: CONVO_LIST_KEY}) | ||
| }, |
There was a problem hiding this comment.
onSettled is called regardless of success.
DogPawHat
force-pushed
the
remove-left-todos
branch
from
c5558a0 to
25e35cf
Compare
DogPawHat
commented
Mar 3, 2025
| @@ -42,7 +36,8 @@ export function useLeaveConvo( | |||
|
|
|||
| return data | |||
| }, | |||
| onMutate: () => { | |||
| onMutate: async () => { | |||
| await queryClient.cancelQueries({queryKey: CONVO_LIST_KEY}) | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from comments in the Tanstack discord made by @mozzius about
useMutationState. I've attempted to give a more "straightforward" answer over there, but I'm doing this pr to tackle the problem hereMy understanding of the issue
I may be horrifically wrong here, but this is what my current reading of the code entails.
If a user leaves and re-joins the convo, the leave convo mutation is still filtering out the convo they just re-joined, and
useLeftConvoswill still have the successful mutation in the cache, filtering out the convo they just rejoined (this is probably the part I'm most unsure of lol). Hence the need to remove the mutation from the mutation cache, which is somewhat non-trivial.A modest proposal
However, it looks like
useLeaveConvois already using the cache optimistic update pattern described here: https://tanstack.com/query/latest/docs/framework/react/guides/optimistic-updates#via-the-cache . Tanstack docs only say to use either the UI or the cache approach, and hence I think we can just deleteuseLeftConvosentirely and we'll be fine anyway.And that's what the PR does.
We also are disabling
useListConvosQueryif there are any pending leave convos mutations in flight so that the optimistic updates will not be overwritten (and the convo flashes up again briefly). This was apparently most of the motivation behinduseLeftConvosin the first place; it makes sense to move that mutation monitoring into the query hook instead.(I've might have another solution as well if you really need to hold on toActually I won't make a pr, might comment on it back in the discord.useLeftConvos, will make an alternative pr.)Testing
Leave conversations and rejoin them with the same people. Only tested the happy path so far; chat with the local backend doesn't seem great to set up.