Skip to content

Remove old Node versions no longer supported by Github actions #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Oct 26, 2023

Conversation

spmiller
Copy link
Contributor

https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Removing support for these older versions (everything below 16) ensures a successful build.

spmiller and others added 30 commits June 22, 2020 18:18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Create a workflow to build on Linux. Add pre-gyp support to build.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fix to python 3.10 

nodejs/node-gyp#2219

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@spmiller
Copy link
Contributor Author

Hi @paulrutter, hopefully you can squash all those commits when you merge, it's a bit embarrassing how many it took to get right since I couldn't test locally.

@paulrutter
Copy link
Contributor

Thanks, i will take a look!

@paulrutter paulrutter merged commit a651dc1 into blueconic:master Oct 26, 2023
@paulrutter
Copy link
Contributor

Didn't manage to squash, bit i did merge the changes and added 20.x to it as well.
Let's see if it works now.

@paulrutter
Copy link
Contributor

@spmiller
Copy link
Contributor Author

Looks like an error in the 20.x branch you added. Perhaps the API is different in v20?

../lib/node_oom_heapdump_native.cc:91:31: error: invalid conversion from ‘void (*)(const char*, bool)’ to ‘v8::OOMErrorCallback’ {aka ‘void (*)(const char*, const v8::OOMDetails&)’} [-fpermissive]

@paulrutter
Copy link
Contributor

I will remove 20.x for now and try again.

@paulrutter
Copy link
Contributor

https://github.com/blueconic/node-oom-heapdump/actions/runs/6651842671

@paulrutter
Copy link
Contributor

I will investigate Node20 later, probably something needs to be added in the code itself first.

@spmiller spmiller deleted the change-to-old-agent branch October 27, 2023 01:39
@paulrutter
Copy link
Contributor

I fixed node20 support and added it to to Github actions: https://github.com/blueconic/node-oom-heapdump/actions/runs/6664282388

@spmiller
Copy link
Contributor Author

Nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants