-
Notifications
You must be signed in to change notification settings - Fork 11
Remove old Node versions no longer supported by Github actions #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Create a workflow to build on Linux. Add pre-gyp support to build.
… into blueconic-master
Fix to python 3.10 nodejs/node-gyp#2219
Hi @paulrutter, hopefully you can squash all those commits when you merge, it's a bit embarrassing how many it took to get right since I couldn't test locally. |
Thanks, i will take a look! |
Didn't manage to squash, bit i did merge the changes and added 20.x to it as well. |
Looks like an error in the 20.x branch you added. Perhaps the API is different in v20?
|
I will remove 20.x for now and try again. |
I will investigate Node20 later, probably something needs to be added in the code itself first. |
I fixed node20 support and added it to to Github actions: https://github.com/blueconic/node-oom-heapdump/actions/runs/6664282388 |
Nice one! |
https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Removing support for these older versions (everything below 16) ensures a successful build.