Skip to content

Fix Windows builds by using latest npm version #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

spmiller
Copy link
Contributor

node-gyp needs to be regularly upgraded to support newer versions of Visual Studio. It seems the simplest way to achieve this is to just upgrade NPM versions to get the latest bundled node-gyp version.

Fixes #22.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
weihanglo Weihang Lo
node-gyp needs to be regularly upgraded to support newer versions of Visual Studio. It seems the simplest way to achieve this is to just upgrade NPM versions to get the latest bundled node-gyp version.
@paulrutter paulrutter merged commit f06ed22 into blueconic:master Feb 10, 2022
@paulrutter
Copy link
Contributor

paulrutter commented Feb 10, 2022

@simon-abbott i published https://github.com/blueconic/node-oom-heapdump/releases/tag/3.0.1 (tagged alpha) so we can test it first before publishing it as stable.
Please let me know how this works for you, it contains the PR of you as well.

See https://www.npmjs.com/package/node-oom-heapdump/v/3.0.1

@paulrutter paulrutter deleted the fix-windows-pre-gyp branch February 10, 2022 12:24
@simon-abbott
Copy link
Contributor

@paulrutter it seems to be working! I'm only using heapdumpOnOOM, so I haven't tested the rest of the api, but heapdumpOnOOM works perfectly for me.

@paulrutter
Copy link
Contributor

Great, i tested the other API's and found no issues.
I marked 3.0.1 as the "latest" release and removed the "alpha" tag, so everyone installing the module will get 3.0.1 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native assets not build on Windows anymore
3 participants