New release 3.0.0 #21
Merged
+884
−749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a heapdump forces a garbage collection, which can then trigger the OOM flow again, which then calls OnOOMError which then creates a heapdump which forces GC which triggers OOM which... This recursive loop is bad for several reasons, not the least of which being if addTimestamp is true it will keep appending the timestamp to the filename, even past the end of the allotted 256 chars. Rather than let this happen let's instead treat it as an error condition and bail.
As noted in the last commit, capturing a heap snapshot forces a garbage collection which can recursively trigger the OOM flow. To prevent this we now raise the heap size limit while capturing this last dump. As far as I can tell this is safe, even in memory-constrained environments, because by the time we get to this section the JS execution has already been halted, so the JS heap won't grow any further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.0.0
This fixes a recursion issue.
gc-stats, which is no longer maintained (and contained security issues)node-pre-gypto@mapbox/node-pre-gypso security issues are mitigatedThis is a backwards incompatible release, as
GC_MONITORINGis no longer supported.