Skip to content

Add default CPU profile duration #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add default CPU profile duration #2

wants to merge 3 commits into from

Conversation

hsiliev
Copy link

@hsiliev hsiliev commented Jan 24, 2018

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@hsiliev hsiliev changed the title Fix comment & JSDoc Add default CPU profile duration Jan 24, 2018
@paulrutter
Copy link
Contributor

paulrutter commented Jan 24, 2018

Thanks for your PR.
I do think the default value of 30000ms is already set in the interface (index.js).

See the following code:

createCpuProfile(cpuProfilePath, duration) {
    if (duration === undefined) {
      duration = 30000;
    } else {
      duration = parseInt(duration);
    }
    return this._impl.createCpuProfile(cpuProfilePath, duration);
  }

That doesn't work for you?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@hsiliev
Copy link
Author

hsiliev commented Jan 25, 2018

Missed that. Thanks for pointing it

@hsiliev hsiliev closed this Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants