Closed
Description
I updated some dependencies and added a few Node versions (and removed some older ones).
@spmiller can you check why this action doesn't succeed anymore?
https://github.com/blueconic/node-oom-heapdump/actions/runs/1822665059
Thanks in advance.
Metadata
Metadata
Assignees
Labels
No labels
Activity
https://github.com/blueconic/node-oom-heapdump/issues/22
https://github.com/blueconic/node-oom-heapdump/issues/22
spmiller commentedon Feb 10, 2022
Hi @paulrutter, sorry about this. It looks like the Windows builds have failed to find Visual Studio, and also that the upload release action we are using thinks it's an error if an asset already exists.
Regarding the Windows builds, it looks like Github have updated the Windows runners to Windows Server 2022 which has probably broken the little hack I used to register it with node-gyp. I'll investigate further and let you know.
paulrutter commentedon Feb 10, 2022
Great! Thanks for the swift response @spmiller
I made some changes on master, but that didn't solve it yet.
spmiller commentedon Feb 10, 2022
Hello again @paulrutter, I submitted a PR to fix the Windows issue. I got green builds with it on my fork.
I didn't look into the 'upload an artifact that is already there' error message -- do you want me to investigate further here or are you OK just deleting the artifacts and re-triggering the build?
paulrutter commentedon Feb 10, 2022
Yes, i think that's fine.
I'll check later today, thanks!
3.0.1
paulrutter commentedon Feb 10, 2022
@spmiller that worked, thanks!
See https://github.com/blueconic/node-oom-heapdump/releases/tag/3.0.1
I'll await some more testing of 3.0.1 and if successful, tag it as latest on NPM.