fix(inspector): call call_end/create_end when inspector shortcircuits calls #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
reviewed
Aug 17, 2023
Evalir
changed the title
revm): remove faulty empty bytecode check & light refactorrevm): call call_end & call_create when shortcircuiting & light refactor
rakita
force-pushed
the
evalir/fix-revm-check
branch
from
711b1c6 to
157244a
Compare
rakita
force-pushed
the
evalir/fix-revm-check
branch
from
157244a to
f3bd77f
Compare
rakita
changed the title
revm): call call_end & call_create when shortcircuiting & light refactor
|
@rakita yep double checking rn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Inspector shortcircuits the call of
call/create, functions for call endcall_end/create_endwere not called, these calls were expected by the foundry and it broke a few things.