Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/hc-12-imports-issue #48

Merged
merged 3 commits into from
Jan 3, 2025
Merged

bugfix/hc-12-imports-issue #48

merged 3 commits into from
Jan 3, 2025

Conversation

jedrzejruta
Copy link
Collaborator

@jedrzejruta jedrzejruta commented Dec 18, 2024 •
edited
Loading

Removed whole registerModule block, since _modules are removed from Highcharts v12.
Updated imports: now they are retrieved from the global Highcharts object.

TODO:

  • Check failing tests and possibly upgrade pixel difference threshold.

@jedrzejruta jedrzejruta self-assigned this Dec 18, 2024
@jedrzejruta jedrzejruta marked this pull request as ready for review January 3, 2025 08:37
@jedrzejruta jedrzejruta requested a review from pawelfus January 3, 2025 08:42
pawelfus
pawelfus approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@pawelfus pawelfus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pawelfus pawelfus merged commit 4ad3aab into master Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelfus pawelfus pawelfus approved these changes

Assignees

@jedrzejruta jedrzejruta

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jedrzejruta @pawelfus @KamilKubik