Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript migration & code refactor #44

Merged
merged 75 commits into from
Nov 18, 2024
Merged

Typescript migration & code refactor #44

merged 75 commits into from
Nov 18, 2024

Conversation

KamilKubik
Copy link
Contributor

@KamilKubik KamilKubik commented Jan 9, 2024 •
edited by jedrzejruta
Loading

TO DO:

  • Adjust the changelog date.
  • Remove the js folder (old core code).
  • Remove/format the bower.json file.
  • Format the gulpfile.js file (gulp tasks).
  • Format the main index.html file (new release).
  • Format the README.md file.

KamilKubik and others added 30 commits October 4, 2023 11:00
@KamilKubik
Added tests mockup for ts refactoring.
c118108
@KamilKubik
Added jest snapshot tests for refactoring
9ce2a32
@KamilKubik
Adjusted code formating
e4169e8
@KamilKubik
Refactored configs/types/tests after review.
cc06021
@KamilKubik
Tests code refactored.
e61b928
@KamilKubik
Added tests refactor.
a3bfebd
@KamilKubik
Merge pull request #41 from blacklabel/regression-tests
dd3babd 
Typescript migration/initial typescript configuration & regression tests
@wchmiel
Added highcharts ts config
776dab6
@wchmiel
Added custom-module schema.
e8b2e72
@KamilKubik
Added build gulp task/formatted files structure.
b15eb37
@KamilKubik
Formatted gulp build script.
a0b3b20
@KamilKubik
Added initial coloredline series refactor version.
5df10c0
@KamilKubik
Added finished version of refactored coloredline series type/structur…
c10a070 
…e global types.
@KamilKubik
Added refactored ESLint config/formatted main ts file & builded package.
e0d5c17
@KamilKubik
Added gulp lint task/husky, pre-commit script to run gulp lint task.
55549c4
@KamilKubik
Refactored core code, ESLint & Husky configs, types structure.
7b51b10
@KamilKubik
Fixed code review issues.
183982b
@KamilKubik
Extracted formatTrackerPath method from drawTracker.
4f21baf
@KamilKubik
Added code review refactor.
73d8518
@KamilKubik
Merge pull request #42 from blacklabel/highcharts-ts-config
e9a853d 
highcharts-ts-config
@KamilKubik
Added coloredarea series refactor.
faa2a7d
@KamilKubik
Refactored MulticolorSeries.ts file.
1ccead5
@KamilKubik
Added MulticolorSeries.ts file formatting.
0d0f2eb
@KamilKubik
Wojtek
6ba817c
@KamilKubik
Added a QUnit package.
513d9ba
@KamilKubik
Changed test reporter (testing).
a578061
@KamilKubik
Changed test reporter (testing).
a06662e
@KamilKubik
Changed test reporter (testing).
a50c1c8
@KamilKubik
Changed pre-commit script.
856af11
@KamilKubik
Refactored unit-tests index.html file.
aea0454
jedrzejruta and others added 18 commits September 18, 2024 18:41
@jedrzejruta
Update babel to target default settings.
106877b
@KamilKubik
Added multicolor series .d.ts types.
52acdb4
@KamilKubik
Merged typescript-migration branch.
0178a4e
@KamilKubik
Formatted compiled .d.ts file.
9f12753
@KamilKubik
Formatted compiled .d.ts file v2.
217a368
@KamilKubik
Removed ds store file.
a07e219
@KamilKubik
Rebacked init method to the core code.
0ec5e18
@jedrzejruta
Add �ugments keyword in class declaration for proper function finding.
fca3af1
@KamilKubik
Refactored series types.
d80d473
@jedrzejruta
Merge pull request #46 from blacklabel/typescript-migration-types
6eb0d3a 
Typescript migration - series types
@KamilKubik
Updated multicolor series d.ts file.
fbbe396
@KamilKubik
Formatted index.html file.
c44feb8
@jedrzejruta
Clean up gulp file, add MIT license.
99f6b20
@KamilKubik
Added finished documentations.
f48e436
@jedrzejruta
Update gulp tasks.
2599a7d
@jedrzejruta
Upgraded demo colors to linear gradient.
4869343
@KamilKubik
Added documentation fixes.
1ba1fab
@KamilKubik
Changed samples directory.
f9a1e25
@KamilKubik KamilKubik requested a review from pawelfus October 8, 2024 08:09
pawelfus
pawelfus requested changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@pawelfus pawelfus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Some minor polishing, though.

To (myself) do:

  • - manual tests (CRUD)

@pawelfus pawelfus self-requested a review November 13, 2024 10:35
@pawelfus pawelfus merged commit bd20312 into master Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedrzejruta jedrzejruta jedrzejruta left review comments

@pawelfus pawelfus pawelfus approved these changes

Assignees

@KamilKubik KamilKubik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KamilKubik @pawelfus @jedrzejruta @wchmiel @mfilipiec