Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-18972] - Fix query for Org By User Domain #5474

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Mar 6, 2025

🎟️ Tracking

PM-18972

📔 Objective

This is to fix the full table scan caused by the wildcard comparison against user email. This also adds index to organization domain.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jrmccannon jrmccannon requested review from a team as code owners March 6, 2025 21:32
@jrmccannon jrmccannon requested a review from BTreston March 6, 2025 21:32
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Logo
Checkmarx One – Scan Summary & Detailsb8aab721-31c0-40c5-a341-d0680e1fa7ea

Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
LOW Log_Forging /src/Api/Platform/Push/Controllers/PushController.cs: 77

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.58%. Comparing base (cb1c127) to head (cb4bb84).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5474      +/-   ##
==========================================
+ Coverage   44.48%   47.58%   +3.10%     
==========================================
  Files        1533     1533              
  Lines       71072    71080       +8     
  Branches     6378     6380       +2     
==========================================
+ Hits        31618    33826    +2208     
+ Misses      38087    35835    -2252     
- Partials     1367     1419      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eliykat eliykat merged commit 6cb97d9 into main Mar 7, 2025
57 checks passed
@eliykat eliykat deleted the jmccannon/ac/pm-18972-domain-query-fix branch March 7, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants