[PM-18555] Notifications service tests

[justindbaur]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-18555

📔 Objective

Add a TON of tests to all our IPushNotificationService implementation so that I can have a higher confidence of not breaking things when I refactor these.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 76125687-b27f-4ca2-921b-fe20d8407609

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	CSRF	/src/Api/Controllers/CollectionsController.cs: 171	details Method Put at line 171 of /src/Api/Controllers/CollectionsController.cs gets a parameter from a user request from model. This parameter value flows... Attack Vector
	Log_Forging	/src/Api/Billing/Controllers/OrganizationBillingController.cs: 263	details Method RestartSubscriptionAsync at line 263 of /src/Api/Billing/Controllers/OrganizationBillingController.cs gets user input from element model. Th... Attack Vector
	Log_Forging	/src/Api/Billing/Controllers/OrganizationBillingController.cs: 263	details Method RestartSubscriptionAsync at line 263 of /src/Api/Billing/Controllers/OrganizationBillingController.cs gets user input from element model. Th... Attack Vector

Fixed Issues (25)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 164
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 133
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 104
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 94
	CSRF	/src/Billing/Controllers/BitPayController.cs: 57
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/RecoveryController.cs: 38
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/RecoveryController.cs: 38
	Log_Forging	/src/Billing/Controllers/RecoveryController.cs: 38
	Log_Forging	/src/Billing/Controllers/RecoveryController.cs: 38
	Log_Forging	/src/Billing/Controllers/RecoveryController.cs: 38
	Log_Forging	/src/Billing/Controllers/RecoveryController.cs: 38
	Log_Forging	/src/Billing/Controllers/RecoveryController.cs: 38
	Log_Forging	/src/Billing/Controllers/RecoveryController.cs: 38
	Log_Forging	/src/Billing/Controllers/RecoveryController.cs: 38
	Log_Forging	/src/Billing/Controllers/RecoveryController.cs: 38
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.41%. Comparing base (c82908f) to head (31bca54).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5473      +/-   ##
==========================================
+ Coverage   44.48%   45.41%   +0.92%     
==========================================
  Files        1533     1533              
  Lines       71075    71082       +7     
  Branches     6377     6377              
==========================================
+ Hits        31618    32281     +663     
+ Misses      38090    37427     -663     
- Partials     1367     1374       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
30.4% Duplication on New Code

See analysis details on SonarQube Cloud