[PM-15015] Add Country Name to auth request from request headers #5471
+9,372
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Requesting country name to pending auth requests for organizations.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5471 +/- ##
==========================================
+ Coverage 44.45% 47.50% +3.04%
==========================================
Files 1530 1534 +4
Lines 71003 70513 -490
Branches 6373 6317 -56
==========================================
+ Hits 31564 33496 +1932
+ Misses 38072 35621 -2451
- Partials 1367 1396 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
New Issues (10)Checkmarx found the following issues in this Pull Request
Fixed Issues (27)Great job! The following issues were fixed in this Pull Request
|
fix : updated sql project stored procedures.
Patrick-Pimentel-Bitwarden
requested changes
Mar 7, 2025
Comment on lines
+24
to
+43
| [dbo].[AuthRequest] | ||
| SET | ||
| [UserId] = @UserId, | ||
| [Type] = @Type, | ||
| [OrganizationId] = @OrganizationId, | ||
| [RequestDeviceIdentifier] = @RequestDeviceIdentifier, | ||
| [RequestDeviceType] = @RequestDeviceType, | ||
| [RequestIpAddress] = @RequestIpAddress, | ||
| [RequestCountryName] = @RequestCountryName, | ||
| [ResponseDeviceId] = @ResponseDeviceId, | ||
| [AccessCode] = @AccessCode, | ||
| [PublicKey] = @PublicKey, | ||
| [Key] = @Key, | ||
| [MasterPasswordHash] = @MasterPasswordHash, | ||
| [Approved] = @Approved, | ||
| [CreationDate] = @CreationDate, | ||
| [ResponseDate] = @ResponseDate, | ||
| [AuthenticationDate] = @AuthenticationDate | ||
| WHERE | ||
| [Id] = @Id |
There was a problem hiding this comment.
🎨 Is this correct tabbing?
Comment on lines
+44
to
+61
| ( | ||
| @Id, | ||
| @UserId, | ||
| @OrganizationId, | ||
| @Type, | ||
| @RequestDeviceIdentifier, | ||
| @RequestDeviceType, | ||
| @RequestIpAddress, | ||
| @RequestCountryName, | ||
| @ResponseDeviceId, | ||
| @AccessCode, | ||
| @PublicKey, | ||
| @Key, | ||
| @MasterPasswordHash, | ||
| @Approved, | ||
| @CreationDate, | ||
| @ResponseDate, | ||
| @AuthenticationDate |
There was a problem hiding this comment.
🎨 Is this the correct tabbing you want?
There was a problem hiding this comment.
For this file, yes. I'm using prettier in vscode and the auto-formatting does this with the 4-space tab as the file default.
| @@ -0,0 +1,168 @@ | |||
| ALTER TABLE | |||
There was a problem hiding this comment.
🎨 This sql file uses 2 space tabbing while I think most of the others use 4. Do we want to keep it consistent?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-15015
Client PR
📔 Objective
We are adding country name from the request header to the
AuthRequestfor better readability for users trying to decide to approve an auth request.📸 Screenshots
Firefox request with header value
firefox_JArBa59XbO.mp4
Video shows the addition of the
country-nameheader value and how the value is saved to the database.Client PR
Screen shots can also be seen in the Client PR
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes