Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15093] Add encstring type 7 (Cose/XChaChaPoly1305] #5470

Draft
wants to merge 1 commit into
base: km/userkey-rotation-v2
Choose a base branch
from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Mar 6, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15093

📔 Objective

This adds server-side support for the new encstring type.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

sonarqubecloud bot commented Mar 6, 2025

Copy link
Contributor

github-actions bot commented Mar 6, 2025

Logo
Checkmarx One – Scan Summary & Detailsa3a4eb7b-b085-4703-ac07-816dac2c4689

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 93
detailsMethod RotateUserAccountKeysAsync at line 93 of /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs gets a parameter from a user ...
Attack Vector
Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
LOW Log_Forging /src/Api/Controllers/DevicesController.cs: 97
LOW Log_Forging /src/Api/Controllers/DevicesController.cs: 97

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.84%. Comparing base (a3734f6) to head (da83ec5).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           km/userkey-rotation-v2    #5470      +/-   ##
==========================================================
- Coverage                   47.78%   44.84%   -2.94%     
==========================================================
  Files                        1538     1538              
  Lines                       71264    71265       +1     
  Branches                     6396     6396              
==========================================================
- Hits                        34050    31961    -2089     
- Misses                      35792    37932    +2140     
+ Partials                     1422     1372      -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant