[PM-18890] Import errors cause permissions are reversed #5469
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5469 +/- ##
==========================================
- Coverage 44.45% 44.45% -0.01%
==========================================
Files 1530 1530
Lines 70999 71021 +22
Branches 6372 6376 +4
==========================================
+ Hits 31562 31570 +8
- Misses 38070 38083 +13
- Partials 1367 1368 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djsmith85
requested changes
Mar 6, 2025
There was a problem hiding this comment.
@voommen-livefront I previously, while working/debugging #5385 I came to the same solution, but it allows a user to create sub-collections within their managed collection. Something which currently we do not want to enable.
IMHO if we want to support this, then we should also enable members to create sub-collections within the organizational vault UI.
Lets discuss this offline with product again.
djsmith85
changed the title
|
New Issues (8)Checkmarx found the following issues in this Pull Request
Fixed Issues (7)Great job! The following issues were fixed in this Pull Request
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-18890
📔 Objective
Given a user, who is not the owner or admin of an organization, but has been giving privileges to Manage a collection, the user must be able to import into that org.
The reason for the failure is this:
ImportCipherprivileges - the program would returnno privilegeCreateprivileges - the program would returnno privilegeThis PR changes it to this:
Import Cipherprivileges - then return 'yes`Createprivilege - then returnyes📸 Screenshots
None at this time
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes