Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test running container images with non-root user #5463

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

tangowithfoxtrot
Copy link
Contributor

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Mar 4, 2025

Logo
Checkmarx One – Scan Summary & Details3f97b02d-41ea-47d8-a7b0-36f0a1ab4339

New Issues (32)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
CRITICAL Stored_XSS /util/Server/Startup.cs: 57
detailsThe method Lambda embeds untrusted data in generated output with WriteAsync, at line 59 of /util/Server/Startup.cs. This untrusted data is embedded...
Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 164
detailsMethod Put at line 164 of /src/Api/AdminConsole/Controllers/GroupsController.cs gets a parameter from a user request from model. This parameter val...
Attack Vector
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 94
detailsMethod Put at line 94 of /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs gets a parameter from a user request from model. This param...
Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 133
detailsMethod Put at line 133 of /src/Api/AdminConsole/Public/Controllers/GroupsController.cs gets a parameter from a user request from model. This parame...
Attack Vector
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 104
detailsMethod Patch at line 104 of /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs gets a parameter from a user request from model. This pa...
Attack Vector
MEDIUM CSRF /src/Identity/Controllers/AccountsController.cs: 119
detailsMethod PostRegister at line 119 of /src/Identity/Controllers/AccountsController.cs gets a parameter from a user request from PostRegister. This par...
Attack Vector
MEDIUM CSRF /src/Api/Platform/Push/Controllers/PushController.cs: 42
detailsMethod PostRegister at line 42 of /src/Api/Platform/Push/Controllers/PushController.cs gets a parameter from a user request from PostRegister. This...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/BitPayController.cs: 56
detailsMethod PostIpn at line 56 of /src/Billing/Controllers/BitPayController.cs gets user input from element model. This element’s value flows through th...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/BitPayController.cs: 56
detailsMethod PostIpn at line 56 of /src/Billing/Controllers/BitPayController.cs gets user input from element model. This element’s value flows through th...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/BitPayController.cs: 56
detailsMethod PostIpn at line 56 of /src/Billing/Controllers/BitPayController.cs gets user input from element model. This element’s value flows through th...
Attack Vector
Fixed Issues (14)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Platform/Push/Controllers/PushController.cs: 51
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 263
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 263
LOW Log_Forging /src/Api/Platform/Push/Controllers/PushController.cs: 43
LOW Log_Forging /src/Api/Platform/Push/Controllers/PushController.cs: 43
LOW Log_Forging /src/Billing/Controllers/BitPayController.cs: 57
LOW Log_Forging /src/Billing/Controllers/BitPayController.cs: 57
LOW Log_Forging /src/Billing/Controllers/BitPayController.cs: 57
LOW Log_Forging /src/Api/Controllers/DevicesController.cs: 191
LOW Log_Forging /src/Api/Controllers/DevicesController.cs: 97
LOW Log_Forging /src/Api/Controllers/DevicesController.cs: 191
LOW Log_Forging /src/Api/Controllers/DevicesController.cs: 97
LOW Unsafe_Use_Of_Target_blank /src/Core/MailTemplates/Handlebars/Auth/TwoFactorEmail.html.hbs: 11
LOW Unsafe_Use_Of_Target_blank /src/Core/MailTemplates/Handlebars/SecurityTasksNotification.html.hbs: 21

@tangowithfoxtrot tangowithfoxtrot changed the title Test docker stuff Test running container images with non-root user Mar 4, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.45%. Comparing base (f80acae) to head (9246805).
Report is 53 commits behind head on main.

Files with missing lines Patch % Lines
src/Core/Utilities/CoreHelpers.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5463      +/-   ##
==========================================
- Coverage   44.51%   44.45%   -0.06%     
==========================================
  Files        1507     1530      +23     
  Lines       69998    71019    +1021     
  Branches     6301     6375      +74     
==========================================
+ Hits        31161    31574     +413     
- Misses      37504    38078     +574     
- Partials     1333     1367      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant