-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove secret check for tests #5454
base: main
Are you sure you want to change the base?
Conversation
|
New Issues (9)Checkmarx found the following issues in this Pull Request
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5454 +/- ##
==========================================
- Coverage 47.55% 44.45% -3.10%
==========================================
Files 1530 1530
Lines 71003 71003
Branches 6373 6373
==========================================
- Hits 33763 31563 -2200
- Misses 35820 38072 +2252
+ Partials 1420 1368 -52 ☔ View full report in Codecov by Sentry. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/VULN-202
📔 Objective
Remove the check for secrets. Replace with logic to identify if the code is running in a fork.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes