Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17122] Add Secrets Manager max projects to organization license #5453

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

amorask-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17122

📔 Objective

The MaxProjectsQuery uses the StaticStore while potentially being self-hosted to get a plan's max projects. In the case of being self-hosted, we need to read that value from the OrganizationLicense instead.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@amorask-bitwarden amorask-bitwarden requested a review from a team as a code owner February 28, 2025 15:49
Copy link
Contributor

github-actions bot commented Feb 28, 2025

Logo
Checkmarx One – Scan Summary & Details3447f864-9757-4fa2-88b5-004f573d4eb0

New Issues (2)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/Public/Controllers/CollectionsController.cs: 87
detailsMethod Put at line 87 of /src/Api/Public/Controllers/CollectionsController.cs gets a parameter from a user request from model. This parameter value...
Attack Vector
LOW Log_Forging /src/Api/Platform/Push/Controllers/PushController.cs: 76
detailsMethod SendAsync at line 76 of /src/Api/Platform/Push/Controllers/PushController.cs gets user input from element model. This element’s value flows ...
Attack Vector

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.

Project coverage is 44.48%. Comparing base (1efc105) to head (d9743cc).

Files with missing lines Patch % Lines
...mplementations/OrganizationLicenseClaimsFactory.cs 0.00% 4 Missing ⚠️
...ecretsManager/Queries/Projects/MaxProjectsQuery.cs 96.29% 0 Missing and 1 partial ⚠️
src/Core/Billing/Licenses/Models/LicenseContext.cs 0.00% 1 Missing ⚠️
...Licenses/Cloud/CloudGetOrganizationLicenseQuery.cs 87.50% 0 Missing and 1 partial ⚠️
.../Core/Services/Implementations/LicensingService.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5453      +/-   ##
==========================================
+ Coverage   44.45%   44.48%   +0.03%     
==========================================
  Files        1530     1530              
  Lines       71002    71034      +32     
  Branches     6373     6377       +4     
==========================================
+ Hits        31564    31603      +39     
+ Misses      38071    38057      -14     
- Partials     1367     1374       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Mar 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants