-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-17122] Add Secrets Manager max projects to organization license #5453
base: main
Are you sure you want to change the base?
[PM-17122] Add Secrets Manager max projects to organization license #5453
Conversation
…elf-hosted instance
New Issues (2)Checkmarx found the following issues in this Pull Request
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5453 +/- ##
==========================================
+ Coverage 44.45% 44.48% +0.03%
==========================================
Files 1530 1530
Lines 71002 71034 +32
Branches 6373 6377 +4
==========================================
+ Hits 31564 31603 +39
+ Misses 38071 38057 -14
- Partials 1367 1374 +7 ☔ View full report in Codecov by Sentry. |
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17122
📔 Objective
The
MaxProjectsQuery
uses theStaticStore
while potentially being self-hosted to get a plan's max projects. In the case of being self-hosted, we need to read that value from theOrganizationLicense
instead.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes