-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: pin minreq
to 2.13.2
, base64ct
to 1.6.0
for MSRV
#1886
base: master
Are you sure you want to change the base?
Conversation
Looks like the same should be done for 1.75. We may also need to pin error[E0658]: use of unstable library feature 'once_cell'
--> /home/runner/.cargo/registry/src/6github.com-1ecc6299db9ec823/minreq-2.13.3/src/connection.rs:22:16
|
22 | static CONFIG: std::sync::LazyLock<Arc<ClientConfig>> = std::sync::LazyLock::new(|| {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #74465 <https://github.com/rust-lang/rust/issues/74465> for more information
error[E0658]: use of unstable library feature 'once_cell'
--> /home/runner/.cargo/registry/src/6github.com-1ecc6299db9ec823/minreq-2.13.3/src/connection.rs:22:57
|
22 | static CONFIG: std::sync::LazyLock<Arc<ClientConfig>> = std::sync::LazyLock::new(|| {
| ^^^^^^^^^^^^^^^^^^^
|
= note: see issue #74465 <https://github.com/rust-lang/rust/issues/74465> for more information
error[E0658]: use of unstable library feature 'once_cell'
--> /home/runner/.cargo/registry/src/6github.com-1ecc6299db9ec823/minreq-2.13.3/src/connection.rs:22:57
|
22 | static CONFIG: std::sync::LazyLock<Arc<ClientConfig>> = std::sync::LazyLock::new(|| {
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #74465 <https://github.com/rust-lang/rust/issues/74465> for more information
Compiling hyper v0.14.32 |
@ValuedMammal done on #1888 . |
These should be in the same PR before we can merge. |
base64ct
to 1.6.0
for MSRVminreq
to 2.13.2
, base64ct
to 1.6.0
for MSRV
Done @ValuedMammal |
Still missing the pin(s) for the 1.75 test in I know it's confusing because we're pinning deps in two places for different rust versions. |
43aa332
to
a186f00
Compare
Now I understand what was going on. Both |
Description
minreq
to2.13.2
because2.13.3
uses the unstablestd::sync::LazyLock
(ci: pinminreq
to2.13.2
,base64ct
to1.6.0
for MSRV #1886 (comment)).base64ct
to1.6.0
for MSRV.Required for #1885 (
ubuntu-24.04
on all CI workflows).Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing