Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin minreq to 2.13.2, base64ct to 1.6.0 for MSRV #1886

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

luisschwab
Copy link
Contributor

@luisschwab luisschwab commented Mar 11, 2025

Description

Required for #1885 (ubuntu-24.04 on all CI workflows).

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@ValuedMammal
Copy link
Contributor

Looks like the same should be done for 1.75. We may also need to pin minreq to fix this

error[E0658]: use of unstable library feature 'once_cell'
  --> /home/runner/.cargo/registry/src/6github.com-1ecc6299db9ec823/minreq-2.13.3/src/connection.rs:22:16
   |
22 | static CONFIG: std::sync::LazyLock<Arc<ClientConfig>> = std::sync::LazyLock::new(|| {
   |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #74465 <https://github.com/rust-lang/rust/issues/74465> for more information

error[E0658]: use of unstable library feature 'once_cell'
  --> /home/runner/.cargo/registry/src/6github.com-1ecc6299db9ec823/minreq-2.13.3/src/connection.rs:22:57
   |
22 | static CONFIG: std::sync::LazyLock<Arc<ClientConfig>> = std::sync::LazyLock::new(|| {
   |                                                         ^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #74465 <https://github.com/rust-lang/rust/issues/74465> for more information

error[E0658]: use of unstable library feature 'once_cell'
  --> /home/runner/.cargo/registry/src/6github.com-1ecc6299db9ec823/minreq-2.13.3/src/connection.rs:22:57
   |
22 | static CONFIG: std::sync::LazyLock<Arc<ClientConfig>> = std::sync::LazyLock::new(|| {
   |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #74465 <https://github.com/rust-lang/rust/issues/74465> for more information

   Compiling hyper v0.14.32

@LagginTimes LagginTimes added the ci label Mar 11, 2025
@notmandatory notmandatory added this to the 1.2.0 milestone Mar 11, 2025
@luisschwab luisschwab mentioned this pull request Mar 11, 2025
3 tasks
@luisschwab
Copy link
Contributor Author

@ValuedMammal done on #1888 .

@ValuedMammal
Copy link
Contributor

@ValuedMammal done on #1888 .

These should be in the same PR before we can merge.

@luisschwab luisschwab changed the title ci: pin base64ct to 1.6.0 for MSRV ci: pin minreq to 2.13.2, base64ct to 1.6.0 for MSRV Mar 12, 2025
@luisschwab
Copy link
Contributor Author

Done @ValuedMammal

@ValuedMammal
Copy link
Contributor

ValuedMammal commented Mar 12, 2025

Still missing the pin(s) for the 1.75 test in cont_integration.yml. The error is shown here https://github.com/bitcoindevkit/bdk/actions/runs/13801087038/job/38603518407

I know it's confusing because we're pinning deps in two places for different rust versions.

@luisschwab
Copy link
Contributor Author

I know it's confusing because we're pinning deps in two places for different rust versions.

Now I understand what was going on. Both 1.63.0 and 1.75.0 required the same pins, but pin-msrv.sh only pins for 1.63.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants